search

alex-oleshkevich / vue-tabler-icons

Fully customizable free SVG icons made as Vue components.
MIT License
150 stars 13 forks source link

[Bug Report] Library doesn't work on IE11 and break application #9

Closed snowgiirl closed 3 years ago

snowgiirl commented 3 years ago

Environment

Lib version: 1.9.0
Vue version: 2.6.11
Browsers: IE11
OS: Windows 10
App created with Vue CLI, integrating all babel plugin, have a browserslistrc etc...

Steps to reproduce

  1. Create app with Vue CLI,
  2. Add and install vue-tabler-icons
  3. Import and display an icon in a template
  4. Go to check application on IE11

Expected Behavior

Application should worked correctly and icon should be displayed

Actual Behavior

Application doesn't work at all, there is an error in Console ':' expected in chunk-vendor.js (I can see the problem is located at the level of icon imports)

Other comment

I think a good configuration of babel should be enough to fix issue

alex-oleshkevich commented 3 years ago

Hi @snowgiirl, I will check what's wrong and try to fix it though I haven't had any plans to support IE11.

alex-oleshkevich commented 3 years ago

I made several updates, pls test if it works and let me know the result. I don't have IE11, (un)fortunately :(

snowgiirl commented 3 years ago

Hello @alex-oleshkevich, I updated the lib to 1.12.1 but it still not working. I found another way to make work my application : I transpile myself your library by adding the following code in vue.config.js :

module.exports = {
    transpileDependendencies: ["vue-tabler-icons"]
}

So I think you can close the issue and my solution will could serve to someone else.

alex-oleshkevich commented 3 years ago

okay, thank you