alex-petrenko / sample-factory

High throughput synchronous and asynchronous reinforcement learning
https://samplefactory.dev
MIT License
773 stars 107 forks source link

Adds milestone saving using periodic timers in runner #202

Closed edbeeching closed 1 year ago

edbeeching commented 1 year ago

Reimplements the milestone logic in the runner.

codecov-commenter commented 1 year ago

Codecov Report

Base: 77.08% // Head: 76.98% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (e6123b3) compared to base (ee73e35). Patch coverage: 36.84% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sf2 #202 +/- ## ========================================== - Coverage 77.08% 76.98% -0.11% ========================================== Files 82 82 Lines 6962 6981 +19 ========================================== + Hits 5367 5374 +7 - Misses 1595 1607 +12 ``` | [Impacted Files](https://codecov.io/gh/alex-petrenko/sample-factory/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko) | Coverage Δ | | |---|---|---| | [sample\_factory/cfg/cfg.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvY2ZnL2NmZy5weQ==) | `100.00% <ø> (ø)` | | | [sample\_factory/algo/learning/learner.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvYWxnby9sZWFybmluZy9sZWFybmVyLnB5) | `87.50% <11.11%> (-1.18%)` | :arrow_down: | | [sample\_factory/algo/learning/learner\_worker.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvYWxnby9sZWFybmluZy9sZWFybmVyX3dvcmtlci5weQ==) | `90.29% <50.00%> (-0.80%)` | :arrow_down: | | [sample\_factory/algo/runners/runner.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvYWxnby9ydW5uZXJzL3J1bm5lci5weQ==) | `88.76% <62.50%> (-0.50%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.