search

alex-petrenko / sample-factory

High throughput synchronous and asynchronous reinforcement learning
https://samplefactory.dev
MIT License
773 stars 107 forks source link

Sf2 cov change #226

Closed wmFrank closed 1 year ago

wmFrank commented 1 year ago

exclude experiments folder from code coverage

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.53% // Head: 80.55% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (09f5223) compared to base (590c70d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sf2 #226 +/- ## ========================================== + Coverage 80.53% 80.55% +0.01% ========================================== Files 92 91 -1 Lines 7368 7364 -4 ========================================== - Hits 5934 5932 -2 + Misses 1434 1432 -2 ``` | [Impacted Files](https://codecov.io/gh/alex-petrenko/sample-factory/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko) | Coverage Δ | | |---|---|---| | [sample\_factory/pbt/population\_based\_training.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvcGJ0L3BvcHVsYXRpb25fYmFzZWRfdHJhaW5pbmcucHk=) | `85.00% <0.00%> (-0.42%)` | :arrow_down: | | [sample\_factory/algo/learning/learner.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2FtcGxlX2ZhY3RvcnkvYWxnby9sZWFybmluZy9sZWFybmVyLnB5) | `87.85% <0.00%> (-0.16%)` | :arrow_down: | | [sf\_examples/atari/experiments/atari\_envs.py](https://codecov.io/gh/alex-petrenko/sample-factory/pull/226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko#diff-c2ZfZXhhbXBsZXMvYXRhcmkvZXhwZXJpbWVudHMvYXRhcmlfZW52cy5weQ==) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aleksei+Petrenko)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alex-petrenko commented 1 year ago

Looks like the coverage didn't change. Did it work?

wmFrank commented 1 year ago

It worked. The report says it increased coverage by 0.01%

alex-petrenko commented 1 year ago

Ok, I suppose you're right. I expected a bigged change, apparently, these scripts contribute very little. Good. Let's merge this and focus on the testing issue!