Closed BartekCupial closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.85%. Comparing base (
23df343
) to head (e1bf6d2
). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR itroduces two small changes to the NetHack example
Fix rendering
Not sure if this is the best way to do this, but I wanted to correctly handle rendering. There is an issue when using
GymV21CompatibilityV0
from shimmy library. Precisely inreset()
they callenv.render()
beforeenv.reset()
which throws an error in NLE.To fix this I've added modified
GymV21CompatibilityV0
wrapper which swaps the order ofenv.reset()
andenv.render()
.Handle timeouts
NLE is compatible with gym==0.21 and it doesn't distinguish between termination and truncation. Normally
GymV21CompatibilityV0
handles this, but it needsinfo["TimeLimit.truncated"]
to do so. I made it work by adding a simple wrapper.