Open Ivan-267 opened 2 months ago
Alternatively, if getpass
is easily available on all platforms, maybe we can just add it to the list of requirements in setup.py?
This requires adding
getpass
to dependencies right?Can we instead use try/catch on
pwd.getpwuid
and if it fails useimport getpass; return getpass...
?
I think getpass
comes with Python and shouldn't need pip install or etc. I didn't use it before however, so I can check more later.
I was able to start Sample Factory training on Windows 10 64 bit using the following:
pip install sample-factory
(then applying the modifications from this PR which changes the UNIX specific PWD module, which caused an error for me on Windows, to one that should hopefully work on both OS types),CPU
(Otherwise there some CUDA detection errors, but I do not have a CUDA device on this PC, so I didn't experiment with that further),True
,I have tested this only with my custom env that uses Godot RL Agents, but I assume it should work for all supported envs.
It needs to be checked if it still works fine on Linux after these changes, I hope the automated tests on the repository will cover this case.