alex-petrenko / sample-factory

High throughput synchronous and asynchronous reinforcement learning
https://samplefactory.dev
MIT License
773 stars 106 forks source link

Fix for Windows training #298

Open Ivan-267 opened 2 months ago

Ivan-267 commented 2 months ago

I was able to start Sample Factory training on Windows 10 64 bit using the following:

I have tested this only with my custom env that uses Godot RL Agents, but I assume it should work for all supported envs.

It needs to be checked if it still works fine on Linux after these changes, I hope the automated tests on the repository will cover this case.

alex-petrenko commented 3 weeks ago

Alternatively, if getpass is easily available on all platforms, maybe we can just add it to the list of requirements in setup.py?

Ivan-267 commented 2 weeks ago

This requires adding getpass to dependencies right?

Can we instead use try/catch on pwd.getpwuid and if it fails use import getpass; return getpass...?

I think getpass comes with Python and shouldn't need pip install or etc. I didn't use it before however, so I can check more later.