search

alex-phillips / clouddrive-php

Amazon Cloud Drive API and CLI for PHP
MIT License
36 stars 9 forks source link

Few Typos #1

Closed therealssj closed 9 years ago

therealssj commented 9 years ago

Thank you for this awesome api! Saved me a lot of work! I found two issues on as follows File.php Line 42 . "tokens/{$this->email}.token"), true); Should be ."{$this->config['tokens_directory']}{$this->email}.token"), true);

File.php line 128 return $response; Should be return $response['data'];

alex-phillips commented 9 years ago

Hey, thanks for the feedback! You're welcome to open up a pull request.

Also, I'm currently rewriting this library as its currently incomplete. The new version is also going to use a SQLite3 cache, so requests don't need to be made for everything such as determining if a node exists, getting metadata, getting parent nodes, etc. Ultimately, it's going to match the functionality of my Ruby project (https://github.com/alex-phillips/clouddrive).

The new rewrite won't be missing anything though. It will still be able to be used as an SDK as well as a command line app.

therealssj commented 9 years ago

Could you possibly add chunked uploading in the new SDK?

alex-phillips commented 9 years ago

When you say chunked, do you mean multi-file or multi-part for a single file?

therealssj commented 9 years ago

Multi-part for single file.

alex-phillips commented 9 years ago

I know Amazon S3 supports that, but I don't see it supported in the CloudDrive API docs. Unless I'm missing it. If you can find where it's supported, I'd be happy to add it.

https://developer.amazon.com/public/apis/experience/cloud-drive/content/nodes

therealssj commented 9 years ago

aah! I thought you would know how to :P I am still looking too :/ Dropped question on developer forum for same.

therealssj commented 9 years ago

Also there was this question on forum and in the answer the guy said it is possible :o Or Does he mean something else when he says chunked transfer encoding?

alex-phillips commented 9 years ago

Ah nice. It may just be a certain way to handle the HTTP request. I'll reply in the forum for more information and see if I can implement it as well. If you find any info, let me know and we'll get it rolled in.

therealssj commented 9 years ago

I contacted support and they said that resumable uploads are in works and will be live in a couple of weeks. Will have to wait till then i guess, i checked the online interface and even that does not do chunked uploads and large files usually timeout.

alex-phillips commented 9 years ago

No problem.

As I mentioned earlier, I'm currently rewriting this codebase. I should have a fairly stable release this weekend if you want to test it out. Will push it up as a new branch (probably refactor).

It's going to be a lot more complete, and with the caching in place, a LOT less API calls will be necessary to perform uploads.

therealssj commented 9 years ago

Sure I would love to test it out!!

On Sat, 11 Jul 2015 2:25 am Alex Phillips notifications@github.com wrote:

No problem.

As I mentioned earlier, I'm currently rewriting this codebase. I should have a fairly stable release this weekend if you want to test it out. Will push it up as a new branch (probably refactor).

It's going to be a lot more complete, and with the caching in place, a LOT less API calls will be necessary to perform uploads.

— Reply to this email directly or view it on GitHub https://github.com/alex-phillips/clouddrive-php/issues/1#issuecomment-120523628 .

alex-phillips commented 9 years ago

Just curious, are you most interested in the library for the CLI or the SDK? Or both? (I'm building the CLI to be an easy-to-use management tool for interacting with CloudDrive. I.e., clouddrive upload FOLDER to upload content)

therealssj commented 9 years ago

I am more interested in the SDK as i am going to use it in a project. Though no problems with me as i can always modify the CLI to meet my needs as i am doing with the current version.

alex-phillips commented 9 years ago

Refactor is live! Let me know what you think.

therealssj commented 9 years ago

Checking it out now! So far i really like it! I see what you meant when you said building for cli , really easy now to operate it using the cli with all these commands available directly!

alex-phillips commented 9 years ago

That was the original reason I built the project, but figured I'd build it out so the SDK was easily developed upon too. Sorry for the lack of docs as of now, hopefully it's pretty self explanatory. Let me know if you have any questions.

Going to go ahead and close this issue, feel free to open others and PRs are always welcome!