search

alex-phillips / clouddrive-php

Amazon Cloud Drive API and CLI for PHP
MIT License
36 stars 9 forks source link

Add forced deletion #18

Closed nikkiii closed 8 years ago

nikkiii commented 8 years ago

Trashed items can be deleted by sending a DELETE request to https://www.amazon.com/drive/v1/nodes/{id}, this PR implements it.

nikkiii commented 8 years ago

It looks like the features merged with the other branch too... If you have any suggestions on how to only make it merge the permanent deletion change, I'd be happy to resubmit it if this breaks it in any way.

alex-phillips commented 8 years ago

I'll review the stream PR first. Once that gets merged in, just rebase this branch and push it up and the only diff should be the delete changes.

As far as permanently deleting a node, I don't see this documented anywhere. How did you find that this endpoint worked?

Thanks for the interest in the project!

nikkiii commented 8 years ago

Well, I guess the url isn't correct in the implementation and I was mistaken to think it worked (I tried it and it seemed to, but that might've been a mixup), but it does exist on the frontend and probably exists SOMEWHERE on the other host.

I'm looking into it now, probably going to have to close this and revert it since I don't think it works :(

nikkiii commented 8 years ago

After some digging it seems I was mistaken in thinking that it'd work here.

From the developer forums:

As of right now permanently deleting content is not available through the Amazon Cloud Drive API.
You can however use the "trash" API to soft delete a node putting contents in the customer's recycle bin.

I'll close this since it doesn't work.