search

alex-pl / fullscreen-plus

A Firefox Add-on which hides the the upper browser toolbars (bookmarks, location, tabs) in fullscreen mode.
https://addons.mozilla.org/firefox/addon/fullscreen-plus/
MIT License
4 stars 1 forks source link

Show address bar when mouse hits the upper display edge #2

Open alex-pl opened 8 years ago

alex-pl commented 8 years ago

Suggested feature from @aemonge in #1:

on mouse hover the address bar wont show up

aemonge commented 8 years ago

^-^

aemonge commented 8 years ago

Hey !!! I've found this plug-ins you might be interested on:

https://addons.mozilla.org/en-US/firefox/addon/nofs/ https://addons.mozilla.org/en-us/firefox/addon/old-lion-fullscreen/

jsoftwareengineering commented 7 years ago

I'm interested in building out this feature since the two linked plugins don't behave so nicely. My intuition is to track the mouse location with javascript and respond when it is at the top of the page, but this doesn't seem like it would be very efficient.

Did you have plans for how to go about this?

alex-pl commented 7 years ago

I had two ideas on how I could implement that.

One of them is to look into mozilla-central (where the code of Firefox lives) and see how it's implemented within Firefox itself for Windows and Linux. That would probably be the most efficient and best user experience.

The second idea is similar to yours. As soon as the full screen mode is entered, I could either listen to the mouse move event or display a one-pixel line at the top of the browser window to detect the mouse position. The second one might be more efficient and I think that's the way how they've implemented it on Windows and Linux.

aemonge commented 7 years ago

This might help, it's a mozilla self plugin that I've just heard: https://github.com/bwinton/TabCenter

Sytten commented 7 years ago

Hey, Nice job for the plugin. Maybe for now we could make a shortcut to enable/disable the plugin (a bit like the F11 key on Windows until we find a better solution. BTW the github repo is very hard to find with such a generic name

alex-pl commented 7 years ago

Maybe for now we could make a shortcut to enable/disable the plugin (a bit like the F11 key on Windows until we find a better solution.

You can use ^ + ⌘ + F to enter and leave the full screen mode. I added this to the Add-on description on AMO.

Edit: Oh, sorry, I got you wrong, the shortcut should show/hide the UI in full screen mode. You're right, that might be a nice way to solve it. But currently I'm wondering whether there's a way this Add-on will continue to work in Firefox 57 and later (because of the exclusive support of WebExtensions). I don't think that there will be APIs to access such low level UI parts anymore. I haven't had time to look into this yet.

BTW the github repo is very hard to find with such a generic name

I've linked it in the Add-on page, somehow the new AMO didn't show it anymore. I fixed it by reentering the address. It's now shown as the Add-on home page in the top right corner.

Sytten commented 7 years ago

Good to hear from you! I am also worried about the WebExtensions exclusivity... I will try to look into it too. I will try to do a PR if I have time to had the F11 shortcut.

Good job for the link, should help getting some help on the project.