Open chadagreene opened 3 months ago
@chadagreene you are correct that this was used in development, I believe Nicole added this. We should:
Rewrite it as a switch and add optional inputs to the thermo function to allow the user to select which method is used.
We should ask Nicole for method definitions
We decided to create a new input, and create a switch as suggested. Also, @chadagreene to go through the other "Idx" inputs and suggest name changes that are less cryptic.
In some recent in-person discussions, @alex-s-gardner suggested simply removing the unreachable sections of code, so I did that in commit d0c292b.
@alex-s-gardner There's a section of code in
thermo.m
that says:The section seems to take the form of a
switch
that would allow the user to select a method of defining constants, but currently none of thefalse
options can ever be reached. Or perhaps this is the result of trying out different methods during the development of the code before settling on a final option?I'd like to clean this up, so should I:
switch
and add optional inputs to thethermo
function to allow the user to select which method is used. If this, please tell me how I should refer to each option.