Open chadagreene opened 1 month ago
I believe S.aValue
is needed when user supplies an a priori albedo for when S.adThresh
is exceeded. @NJSchlegel added this and can confirm
S.cciceValue
should be 'black_carbon_concentration_iceor
light_absorbing_carbon_concentration_ice
S.ccsnowValueshould be 'black_carbon_concentration_snow
or light_absorbing_carbon_concentration_snow
Variables with ?
are owned by @NJSchlegel
dulwrfValue is if the user wants to run sensitivity tests to perturb LW up. I am doing this myself, so it made sense to add an option for it instead of keep hacking inside the code. It didn't make sense for me to remove that functionality once it was built in. Don't we need Dzini to define the mx1 depth of the layers of all the ini variables? Sizeini is the "m" of all the ini variables, which in matlab can just be calculated, but for c++ it is helpful to pass in. Maybe mini is more meaningful? cotValue should be 0.0 I believe, as set it MASTER_RUN.m . S.C is a mean of the accumulation, so does not technically have a default. It should be an input (like S.Tmean and S.Vmean). Also, I think Vmean needs to have a value > 0. In ISSM, the input uses 10 m/s. Also agree with @alex-s-gardner, aValue will need to be set for the case when adThresh is exceeded (not just when the albedo option is constant).
In reference to Issue #19, I'd like to consider renaming the variables that input to the
GEMB
function and setting their default values as described below. What are your thoughts on these potential changes?