added few configurable options

alex-saunders / sliding-pages

🎠 A polymer 2.0 element designed for page transitions in a carousel style

https://www.webcomponents.org/element/alex-saunders/sliding-pages

MIT License

10 stars 4 forks source link

added few configurable options #3

Open daniel-vlad opened 7 years ago

daniel-vlad commented 7 years ago

Hi Alex!

I've added a few more configurable options to the component. Please check them out and see if you think it might be worth adding them to the main branch.

Also it seems that VsCode auto format messed with the formatting/indenting you had before, if that's a problem please let me know and i will change it back.

exposed a swipeThreshold property which will help decide when the page is switched
exposed a swipeRatio property which will reflect percentage of the viewport the current page has been swiped
exposed a transitionTime property which lets you decide the transition time between pages (if it's not set it will use the calculations you initially added for the decision)
exposed a swipingDirection property. will let other components know which direction the pages are being swiped.

alex-saunders commented 7 years ago

Hi @daniel-vlad ,

Sorry for the slow response! Which version of Polymer were you using to develop these updates? I'm getting a whole heap of errors in my console when testing this locally. Will have a deeper look into it asap but just wondering if there could be a quick fix here.

Cheers for the PR!

daniel-vlad commented 7 years ago

Hi @alex-saunders,

No worries :). I didn't mess with the polymer version it's still "polymer": "Polymer/polymer#^2.0.0-rc.2", however it seems that in my hurry to change stuff i forgot to adapt the demo to the changes so that's probably why you're getting all those errors (sorry about that).

I will make the changes as soon as i get some time and will let you know when it's done.

shawnd commented 7 years ago

@daniel-vlad any updates on your PR?

daniel-vlad commented 7 years ago

@shawnd (sorry for the late response) haven't had a chance to look at it been a crazy busy month. I will adapt it to take in the latest pull request from @alejost848 when i fix the demo

alex-saunders commented 6 years ago

@daniel-vlad any updates on this? (I realise it's been a while so no worries if you've forgotten about it)

alejost848 commented 6 years ago

@daniel-vlad @alex-saunders Any updates on this PR? Is there anything I can do to help?

daniel-vlad commented 6 years ago

@alex-saunders, @alejost848 : sorry, haven't had a chance to get to it in a while. Mostly just need to fix the demo if I remember right, I will take a look at it tomorrow evening and give you guys a proper update

daniel-vlad commented 6 years ago

Slight update: looks like the problem is bigger than just the demo pages, i'm looking into it now

daniel-vlad commented 6 years ago

Ok, finally got the time to take a proper look and pushed some more changes. Seems fine now, please let me know if you find any more issues and sorry for the HUGE delay again. ^^