search

alex-setyawan / pe

0 stars 0 forks source link

Unchanged command format for "add" in Notes section #10

Open alex-setyawan opened 5 months ago

alex-setyawan commented 5 months ago

When adding new people into the app, the "add" command cannot take in special characters such as commas, so this example in the Notes section might confuse readers at first.

image.png

Evidence names cannot take special characters:

image.png

nus-pe-bot commented 5 months ago

Team's Response

Duplicate of #2339

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Over restrictive name validation to be only alphanumeric - some legal names not allowed

Description Set the context.

This app is used in a clinical context, which mean patient names are usually saved in full. However, some legal names containing non-alphanumeric characters are not allowed to be added into the system.

image.png

Steps to reproduce

  1. Launch the application for the first time to load initial data.
  2. Run add ic/S9987654A p/98887777 n/Ramy s/o Shanmugam g/M b/02-10-99 e/ramy@gmail.com d/General Flu

Expected behaviour

To be able to add this patient and his details.

Actual behaviour

Disallowed.

image.png

Reason for severity

This may cause inconvenience to the doctors who are not able to save their patients' names containing characters like ' or / or -, when they are common amongst people.

[original: nus-cs2103-AY2324S2/pe-interim#2957] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Such issue is of valid concern especially for foreign names that contains special symbols. The team has actually taken note of this particular use case and it was unfortunately not included in the planned enhancements. Hence Accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is being raised not regarding any feature of the app. Rather, it is about the documentation not being updated to match the app's current functionality. The user guide states that using commas under the "name" field is allowed, when special characters are not allowed in the "name" field. Rectification requires the user guide to be updated so that it matches the current state of the app and users won't be confused when using it.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** This issue is being raised not regarding any feature of the app. Rather, it is about the documentation not being updated to match the app's current functionality. The user guide states that using commas under the "name" field is allowed, when special characters are not allowed in the "name" field. Rectification requires the user guide to be updated so that it matches the current state of the app, and users won't be confused when using it.