search

alex-setyawan / pe

0 stars 0 forks source link

"Add" command takes in empty input for "drug_allergy" field #5

Open alex-setyawan opened 2 months ago

alex-setyawan commented 2 months ago

The "add" command does not check for valid alphanumeric strings when taking in the drug allergy field, potentially redundantly storing drug allergies which are not meaningful.

Steps to reproduce:

  1. Type "add ic/S9974944F n/John Doe p/91234567 e/johndoe@email.com g/M b/11-11- 1990 d/ | | | | i/Infectious Diseases"

  2. Press "Enter"

The result is as follows (index 27):

Screenshot 2024-04-19 164234.png

soc-pe-bot commented 2 months ago

Team's Response

Duplicate of #5429

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Special characters recorded as drug allergies in add command

image.png

command: add ic/S9974944F n/John Doe p/91234567 e/johndoe@email.com g/M b/11-11-1990 d/|| | | || i/Infectious Diseases Here the separator characters are actually recorded as drug allergy types in the app, leading to confusion. Should consider imposing some restrictions on the type of information to be placed between separators.

[original: nus-cs2103-AY2324S2/pe-interim#4991] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

When developing drug allergy functionality, we have decided to allow the user to have the flexibility to input any information related to the drug allergy field. This could include explanation on specific person's reaction for a specific drug allergy, or in rare occasion where clinics has some SOP where they have symbols that represent a respective drug allergy, which in that case they can just enter that symbol in the field. We aim to make it flexible enough for various use cases that various clinics might have. Though, regarding overzealous validation the bug issue can be addressed in by simply adding some warning messages that only symbols are inputted in the future releases. Hence marking this NotInScope

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]