search

alex-seville / grunt-blanket

grunt task to instrument files for code coverage using Blanket.js
http://blanketjs.org
MIT License
29 stars 6 forks source link

Expose data-cover-customVariable #6

Closed laurelnaiad closed 10 years ago

laurelnaiad commented 10 years ago

Expose the data-cover-customVariable parameter of blanket so that grunt-blanket may be used to instrument code to be reported in the browser via blanket.

laurelnaiad commented 10 years ago

I actually have a few more changes -- do you want me to merge them all as one PR, request them all separately now, or spoon feed you to avoid merge conflicts?

For heads up purposes, the config options look like this when all are included:

      "data-cover-customVariable": options['data-cover-customVariable'],
      "data-cover-flags": options['data-cover-flags'], // this would be a breaking change to clean up flags that are passed
      "data-cover-filename-format": options['data-cover-filename-format'], // goes along with a blanket PR I'm submitting
      "data-cover-only": options["data-cover-only"] || options["pattern"] || "*"

In addition, I have a change to support data-cover-never in grunt-blanket but it doesn't get passed to blanket because the task manually selects files to send to blanket.

alex-seville commented 10 years ago

Separate PR's are probably the best idea since each change might have different effects/implications

thanks.

On Sat, Sep 14, 2013 at 1:26 PM, Stu Salsbury notifications@github.comwrote:

I actually have a few more changes -- do you want me to merge them all as one PR, request them all separately now, or spoon feed you to avoid merge conflicts?

For heads up purposes, the config options look like this when all are included:

  "data-cover-customVariable": options['data-cover-customVariable'],
  "data-cover-flags": options['data-cover-flags'], // this would be a breaking change to clean up flags that are passed
  "data-cover-filename-format": options['data-cover-filename-format'], // goes along with a blanket PR I'm submitting
  "data-cover-only": options["data-cover-only"] || options["pattern"] || "*"

In addition, I have a change to support data-cover-never in grunt-blanket but it doesn't get passed to blanket because the task manually selects files to send to blanket.

— Reply to this email directly or view it on GitHubhttps://github.com/alex-seville/grunt-blanket/pull/6#issuecomment-24458478 .

laurelnaiad commented 10 years ago

Ok, if I do them now they're all going to require manual merging -- do you want that or do you want me to do one at a time based on the result of the previous?

alex-seville commented 10 years ago

Maybe submit one at a time in order. That way if they're accepted and merged in order there shouldn't be a problem.

On Sat, Sep 14, 2013 at 4:27 PM, Stu Salsbury notifications@github.comwrote:

Ok, if I do them now they're all going to require manual merging -- do you want that or do you want me to do one at a time based on the result of the previous?

— Reply to this email directly or view it on GitHubhttps://github.com/alex-seville/grunt-blanket/pull/6#issuecomment-24461207 .

laurelnaiad commented 10 years ago

Sounds good. Well you have the first.