search

alex / letsencrypt-aws

BSD 3-Clause "New" or "Revised" License
727 stars 121 forks source link

Finished CloudFront support #61

Open amw opened 8 years ago

amw commented 8 years ago

These are my fixes for your PR #44 that fixes #41. Using this I was able to create, upload and configure certificate for my CloudFront distribution that didn't even use any SSL cert before. After that I've verified that on a second run the existing cert is checked for its settings and expiration time.

I didn't realize I was working in parallel with @kageurufu who submitted #56. I like his --cert-only option, but we took different approaches. I've based my PR on your topic branch and put my changes in multiple separate commits hoping it will make them easier to review.

alex commented 8 years ago

FYI, I plan to review this this weekend.

gigabo commented 8 years ago

Hi! What's the status of this? We'd like to use it!

amw commented 8 years ago

Seems that this PR is lost. So many commits on master that it would have to be rewritten.