search

alex / letsencrypt-aws

BSD 3-Clause "New" or "Revised" License
728 stars 121 forks source link

enable configuration via file (preferring environment) #88

Closed dlamotte closed 2 years ago

dlamotte commented 8 years ago

Systems like kubernetes allow you to specify configuration via a configmap/secret which can be updated and will update the file within the container. Environment variables do not have this feature. When it comes to managing this inside a container in a kubernetes cluster, this will allow you to update the configuration without restarting the container.

Current configurations will not be broken as the environment variable is still in use and preferred. To use this feature, you must only set the LETSENCRYPT_AWS_CONFIG_FILE environment variable but will default to config.json in the directory its run from.

dlamotte commented 8 years ago

Fixed up flake8 issues.

dlamotte commented 8 years ago

@alex Just want to say thanks for merging my other pull requests. I have a few other branches dependent on this one... would you prefer separate PRs or one big one?

alex commented 8 years ago

Always separate PRs.

On Thu, Oct 13, 2016 at 5:46 PM, Dan LaMotte notifications@github.com wrote:

@alex https://github.com/alex Just want to say thanks for merging my other pull requests. I have a few other branches dependent on this one... would you prefer separate PRs or one big one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alex/letsencrypt-aws/pull/88#issuecomment-253648374, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADBHIu5mTk6QJlTCtUXDwnFTGBhEx3ks5qzqa9gaJpZM4KUIHn .

"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: D1B3 ADC0 E023 8CA6