Fix batch trend calculations - Githubissues

alex / nyt-2020-election-scraper

https://alex.github.io/nyt-2020-election-scraper/battleground-state-changes.html

MIT License

1.76k stars 289 forks source link

Fix batch trend calculations #355

Closed saleemrashid closed 3 years ago

saleemrashid commented 3 years ago

Motivation

Similarly to #348, we should use the vote delta for the two leading candidates instead of the overall vote delta.

Fixes #353.

Changes

Use new_votes_relevant (the variable introduced by #348) instead of new_votes when calculating the hurdle moving average.

[x] Ensured that you have rebased your branch with this repo's latest master branch.
[x] Ensured that relevant issues are linked, if this PR resolves any outstanding.
[x] Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
[x] Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv, *.xml and *.json files.