search

alex / nyt-2020-election-scraper

https://alex.github.io/nyt-2020-election-scraper/battleground-state-changes.html
MIT License
1.76k stars 289 forks source link

Update print-battleground-state-changes to cap hurdles at 100% #377

Closed eebasso closed 3 years ago

eebasso commented 3 years ago

The hurdles will grow beyond 100%. Should we cap them there or at 1000%? Currently this should do it at 100%. Simple change. Sorry for being noob, this is my first pull request.

fractionalhare commented 3 years ago

I can see you put some effort into this pull request, but we're really not interested in changing the way the hurdle rate is represented. I don't mean this to be discouraging, given that you proposed this and implemented the change in earnest. We discussed this internally and want to err on the side of presenting more information rather than less, even if that means numbers like the hurdle rate become (humorously) large.

eebasso commented 3 years ago

Yeah I think more information is good. Maybe the cap should not be at 100%. But the information has to be capped at some point right? Otherwise it will blow up off the charts. You could set the cap at 1000% or 10000% or whatever you want. You can use my code to do that if you decide that's what you want to do in the future. Obviously all you'd need to change is the 1 to a 10 or 100 and change the wording to "1000%" or "10000%." I had fun making this PR, it's okay if it doesn't get used.