Use state abbreviations for notifications - Githubissues

alex / nyt-2020-election-scraper

https://alex.github.io/nyt-2020-election-scraper/battleground-state-changes.html

MIT License

1.76k stars 289 forks source link

Use state abbreviations for notifications #380

Closed saleemrashid closed 3 years ago

saleemrashid commented 3 years ago

Motivation

Fixes #378

Changes

This busts the cache because we weren't including state_id in InputRecord before.

I haven't actually tested the notifications, but the diff looked correct to me. The HTML file was the only generated file that changed, and the only change was states_updated in this line changing to abbreviations: https://github.com/alex/nyt-2020-election-scraper/blob/7ad43fb804c0977cc927bb172f4d95472a618fec/battleground-state-changes.html#L219

[x] Ensured that you have rebased your branch with this repo's latest master branch.
[x] Ensured that relevant issues are linked, if this PR resolves any outstanding.
[ ] Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
[x] Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv, *.xml and *.json files.