search

alex / rply

An attempt to port David Beazley's PLY to RPython, and give it a cooler API.
BSD 3-Clause "New" or "Revised" License
381 stars 60 forks source link

Improve ParserGenerator readability #29

Open djc opened 10 years ago

djc commented 10 years ago

I'm not sure why you wrote it this way, but adding a few empty lines, early continues and inverting conditions to handle simple cases first seems to me like it makes this code much more readable.

djc commented 9 years ago

Merged with master, please consider (use git diff -w to check that nothing substantially changes).

djc commented 8 years ago

Hey @alex, any more feedback?

djc commented 6 years ago

@alex this still applies after 3 years and was also useful when I was adding some debugging to the parser generator code. Please consider for merging or just close it if you think it's not an improvement.