search

alex / rply

An attempt to port David Beazley's PLY to RPython, and give it a cooler API.
BSD 3-Clause "New" or "Revised" License
381 stars 60 forks source link

adapt to rpython changes #76

Closed cfbolz closed 6 years ago

cfbolz commented 6 years ago

Hi Alex!

I fixed the current RPython breakage. I also changed the way Rule is made translatable to a more minimal approach. I tried to adapt the current approach, but gave up after half an hour. Hope it's acceptable to switch approaches like this, if not, let me know.

alex commented 6 years ago

Hi Carl,

This looks great to me. There's a handful of flake8 errors (you can ignore the E741 ones though), then this looks ready to merge!

cfbolz commented 6 years ago

Ah, sorry, travis is telling me to clean up the rpython imports. on it.

cfbolz commented 6 years ago

Thanks a lot Alex! Sorry, should have been a bit more careful with my flake8 compliance.

alex commented 6 years ago

Thanks for cleaning this up!

On Mon, May 21, 2018 at 8:15 AM Carl Friedrich Bolz-Tereick < notifications@github.com> wrote:

Thanks a lot Alex! Sorry, should have been a bit more careful with my flake8 compliance.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/alex/rply/pull/76#issuecomment-390637301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADBMBkPAugf14oqvEUpklN7ICFuiSGks5t0q_XgaJpZM4UG0_g .

-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: D1B3 ADC0 E023 8CA6