Closed cfbolz closed 6 years ago
Hi Carl,
This looks great to me. There's a handful of flake8 errors (you can ignore the E741 ones though), then this looks ready to merge!
Ah, sorry, travis is telling me to clean up the rpython imports. on it.
Thanks a lot Alex! Sorry, should have been a bit more careful with my flake8 compliance.
Thanks for cleaning this up!
On Mon, May 21, 2018 at 8:15 AM Carl Friedrich Bolz-Tereick < notifications@github.com> wrote:
Thanks a lot Alex! Sorry, should have been a bit more careful with my flake8 compliance.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/alex/rply/pull/76#issuecomment-390637301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADBMBkPAugf14oqvEUpklN7ICFuiSGks5t0q_XgaJpZM4UG0_g .
-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: D1B3 ADC0 E023 8CA6
Hi Alex!
I fixed the current RPython breakage. I also changed the way Rule is made translatable to a more minimal approach. I tried to adapt the current approach, but gave up after half an hour. Hope it's acceptable to switch approaches like this, if not, let me know.