search

alex / rply

An attempt to port David Beazley's PLY to RPython, and give it a cooler API.
BSD 3-Clause "New" or "Revised" License
381 stars 60 forks source link

Fix version check for MutableMapping import #85

Closed jwilk closed 5 years ago

jwilk commented 5 years ago

Abstract base classes were moved from collections to collections.abc only in Python 3.3.

alex commented 5 years ago

3.4 is the minimum version of Python 3 we currently support (at least, based on our travis CI config), so I don't think this is necessary. Do you disagree?

jwilk commented 5 years ago

Before bc214723afd2e456b243de094fd5ee2ea322b753, rply worked fine with Python 3.2, even if that was not officially supported. Personally, I don't have any use for rply on Python 3.0-3.2. I submitted this because the code was misleading to human readers, and it was trivial to fix.

alex commented 5 years ago

Ok, I guess I'll merge it, as it does not harm. (If we were using six.PY3 or something like that, I'd say no :-)).