alex1818 / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
0 stars 0 forks source link

Non-intuitive errror message when "serfmake install" fails due to perms #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Build serf (e.g. serfmake --prefix=/opt/serf build)
2. Try to install without proper FS permissions
3. The error will be something like

loki (09:08) 345/1 $ ./serfmake --prefix=/opt/serf install
ERROR: exception:
[Errno 2] No such file or directory: '/opt/serf/include/serf-0'

A simple patch (catching the exception earlier), would produce a slightly more 
useful error message:

loki (09:09) 351/1 $ ./serfmake --prefix=/opt/serf  install
ERROR: exception:
('os.makedirs', 'can not create install directories')

Original issue reported on code.google.com by lhedst...@gmail.com on 12 Jul 2010 at 3:12

GoogleCodeExporter commented 9 years ago

Original comment by lhedst...@gmail.com on 12 Jul 2010 at 3:14

Attachments:

GoogleCodeExporter commented 9 years ago
But this raises an error if the target directories already exist. We want to be 
able to re-install, or be able to install into existing areas (eg. /usr/local).

If you can refine the patch, then I'll happily apply it.

Original comment by gstein on 13 Jul 2011 at 6:47

GoogleCodeExporter commented 9 years ago
How about something like this?

Original comment by lhedst...@gmail.com on 13 Jul 2011 at 6:23

Attachments:

GoogleCodeExporter commented 9 years ago
I rejiggered the patch to tighten the except: scope, then applied it. Fixed in 
r1532.

Thanks!

Original comment by gstein on 13 Jul 2011 at 10:42