search

alex3165 / react-mapbox-gl

A React binding of mapbox-gl-js
http://alex3165.github.io/react-mapbox-gl/
MIT License
1.93k stars 535 forks source link

Support React >=17 #923

Open snickell opened 3 years ago

snickell commented 3 years ago

JupyterLab 3 and a few other projects are switching pretty aggressively to React 17, which carries the promise of less need to pin library components (like react-mapbox-gl) to particular React releases. In theory React 17 paves the way for more flexible intermixing of react dependencies by library bindings, so people could use react-mapbox-gl in the future with 17, 19, and 23 without react-mapbox-gl having to hardcode support for one or the other.

I tried a basic "bump version in package.json to react>=17 and see what happens", but it wasn't a quick-fix, I'll try to find time to push what work I already did as a PR.

guilhermestorck commented 3 years ago

Any luck with this? I was about to create the same PR but I'd like to hear from your first.

snickell commented 3 years ago

Nope, not a ton of luck yet

cigzigwon commented 3 years ago

this works in React 17 but is a a piece of junk! The solution I came up with costed more time then just porting over my own useMapbox hook in another project.