search

alex3305 / home-assistant-addons

Alex's Home Assistant Add-ons
https://alex3305.github.io/home-assistant-docs/
MIT License
47 stars 29 forks source link

dnsChallenge LAN changes #12

Closed leakypixel closed 3 years ago

leakypixel commented 3 years ago

While using this addon to make a dnsChallenge certificate request, I ran into a couple of issues relating to DNS on my LAN not mirroring that of the public internet, as well as special characters in API keys.

In order to make this work for me, I had to make a couple of changes to allow escape characters in env vars, and add delayBeforeCheck and resolvers to the generated traefik static config.

I also tidied up a little around the previous PR I made, by adding the references to aarch64 in the config and build files.

leakypixel commented 3 years ago

I believe that's the changes done - apologies for the reformatting, it was a complete oversight.

Thanks for taking the time to review this, let me know if there're any other changes required :)

alex3305 commented 3 years ago

Thanks for the changes you have made. I have accepted your PR.

When I requested additional documentation I thought that the docs were still in the Readme, but I forgot that they were moved to the Docs file. I will move them for you. I will also update the add-on version, so your changes will be available through an update of this add-on.

Thanks again for your contribution and the nice collaboration!