alex3305 / home-assistant-addons

Alex's Home Assistant Add-ons
https://alex3305.github.io/home-assistant-docs/
MIT License
47 stars 29 forks source link

Fix s6 execution #50

Closed yo1frenchtoast closed 10 months ago

yo1frenchtoast commented 10 months ago

Sorry I broke your addon, there was an issue with s6 overlay which was introduced as a breaking change in HA 2022.6 (s6-overlay-suexec: fatal: can only run as pid 1; https://www.home-assistant.io/blog/2022/06/01/release-20226/#breaking-changes)

I fixed by setting 'init: false' in config.yml and adding several execution rights on init, run and finish scripts

Here is logs from my working version

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service base-addon-banner: starting

-----------------------------------------------------------
 Add-on: Traefik
 Traefik is a modern HTTP reverse proxy and load balancer that makes deploying
microservices easy.
-----------------------------------------------------------
 Add-on version: 4.2.1
 You are running the latest version of this add-on.
 System: Home Assistant OS 11.1  (amd64 / generic-x86-64)
 Home Assistant Core: 2023.11.1
 Home Assistant Supervisor: 2023.11.0
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
Log level is set to INFO
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service legacy-cont-init: starting
cont-init: info: running /etc/cont-init.d/traefik.sh
[17:14:57] INFO: Ensuring SSL directory...
[17:14:57] INFO: Generating static config...
[17:14:57] INFO: Static config generated
cont-init: info: /etc/cont-init.d/traefik.sh exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun nginx (no readiness notification)
services-up: info: copying legacy longrun traefik (no readiness notification)
[17:14:57] INFO: No additional environment variables found
[17:14:57] INFO: Starting Traefik...
[17:14:57] INFO: Running Traefik without env_vars
s6-rc: info: service legacy-services successfully started
time="2023-11-09T17:14:57+01:00" level=info msg="Configuration loaded from file: /etc/traefik/traefik.yaml"
time="2023-11-09T17:14:57+01:00" level=info msg="Traefik version 2.10.5 built on 2023-10-11T13:54:02Z"
time="2023-11-09T17:14:57+01:00" level=info msg="\nStats collection is disabled.\nHelp us improve Traefik by turning this feature on :)\nMore details on: https://doc.traefik.io/traefik/contributing/data-collection/\n"
time="2023-11-09T17:14:57+01:00" level=info msg="Starting provider aggregator aggregator.ProviderAggregator"
time="2023-11-09T17:14:57+01:00" level=info msg="Starting provider *file.Provider"
time="2023-11-09T17:14:57+01:00" level=info msg="Starting provider *traefik.Provider"
time="2023-11-09T17:14:57+01:00" level=info msg="Starting provider *acme.ChallengeTLSALPN"
time="2023-11-09T17:14:57+01:00" level=error msg="the router homeAssistantRouter@file uses a non-existent resolver: le"
[17:14:58] INFO: Starting Nginx for dashboard...

Hope I didn't mess up yall, have a good day 🙏

alex3305 commented 10 months ago

No worries friend, 💩 happens. Thanks for noticing and fixing it asap.

Would you be so kind also upping the version number and amending the changelog in a new PR? That would be great.

Thanks again for your contribution 🚀 !

yo1frenchtoast commented 10 months ago

Sure, doing, thanks =)