search

alex35mil / dotfiles

My dotfiles
230 stars 10 forks source link

Zellij runner doesn't update on change directory screen #3

Closed praveenperera closed 1 year ago

praveenperera commented 1 year ago

Hey great dotfiles by the way, using it to switch from tmux to zellij.

When I run zellij runner, sometimes the UI doesn't update on the change directory screen and I have to quit the terminal. This happens every time I say yes on the "change directory" screen. The screen does not change and and everything appears to get stuck.

I'll update this issue with more info or a PR if I figure it out. Thought you might have an idea on what's happening.

tlvenn commented 1 year ago

Just discovered the runner and running into the same issue on OSX if that matters.

praveenperera commented 1 year ago

I’m also on MacOS

alex35mil commented 1 year ago

@praveenperera @tlvenn

Hey, the directory chooser is hella non-optimized, and I think there might be issues when there are a lot of directories in the search scope.

Have you tried to narrow the search scope by setting env vars described here?

praveenperera commented 1 year ago

@alex35mil yup that's definitely, the issue. I let it run just took a while.

alex35mil commented 1 year ago

Yeah, it would need async to optimize dir picker, but I didn't get around to exploring how it would play with tui lib.

praveenperera commented 1 year ago

@alex35mil maybe incorporating Skim would the faster and easier option.

I haven't tried it but i’m assuming it would give you progress indication so people wouldn’t think it’s frozen.

alex35mil commented 1 year ago

@praveenperera I considered it for the first version of the runner, but it didn't work out for some reason. I don't remember why. For the current version, I was just lazy and did a primitive search with ignore (used in ripgrep). Makes sense to try out Skim with the current version of the runner as UI is much more low-level and allows pretty much everything if it is not async.