search

alex47 / KDE-Rounded-Corners

Rounds the corners of your windows
GNU General Public License v3.0
166 stars 15 forks source link

Could corners look better? #13

Open saligari opened 5 years ago

saligari commented 5 years ago

screenshot_20190226_154318

The corners sometimes look a bit like there's a bit of grey when the window is dark on light background.

asaphaaning commented 5 years ago

I have this problem on the non-CSD apps too. https://i.imgur.com/rX3mmOy.png

alex47 commented 5 years ago

that's because of the way shadows are rendered the decoration creates the shadow and then passes it to kwin, so the window and shadows are not rendered at the same time

what you see there is the shadow behind the window is masked out, so it doesn't affect transparency behind the window, and the mask is a rounded rectangle with a radius of 3

this effect rounds the window, but the shadow is untouched

the breeze theme makes a rounded rectangle with a radius of 3, so the best workaround is to decrease the radius of this effect to 3 here: https://github.com/alex47/KDE-Rounded-Corners/blob/master/shapecorners.cpp#L166

another workaround is to disable shadows in the breeze window decoration settings I don't think this issue can be solved without touching the shadow rendering or the breeze theme

asaphaaning commented 5 years ago

Seems like even with a full disabling of shadows, the blur still messes with the border radius. I suppose that makes it a dead end too huh?