search

alex7kom / node-steam-tradeoffers

Steam Trade Offers for Node.js **NO LONGER MAINTAINED**
MIT License
287 stars 100 forks source link

Fix acceptOffer() not working #282

Closed luop90 closed 7 years ago

luop90 commented 7 years ago

Valve changed how offers are accepted awhile back, and acceptOffer() as it stands no longer functions. You have to add the partner steam id to the form being passed.

This PR fixes this, and updates the readme / example for the new change.

alex7kom commented 7 years ago

Thank you! Please give some time to review the changes.

luop90 commented 7 years ago

Done. Switched from the offer -> options object

alex7kom commented 7 years ago

Thank you!

It is strange but accepting offers works for me with the current library code. Although I think partner param should be added because it exists on Steam Community site, it would be great if we could investigate this further.

luop90 commented 7 years ago

Odd that it works for you, because I haven't been able to get it to work at all without the partner parameter. Do you have mobile confirmations enabled? That might change how offers are accepted (because if the partner has been a friend for longer than a year (?), then the hold time is much shorter.)

andrewda commented 7 years ago

Seems to work for me with and without partner. Still, if it exists on Steam Community, it should exist here. :+1:

alex7kom commented 7 years ago

Thank you! Landed in https://github.com/Alex7Kom/node-steam-tradeoffers/commit/ffda3d05520e0cef4aa325784b991dd751e117e8. I decided to make it an optional param after all, and this allowed a patch semver release.