alex8088 / electron-vite-boilerplate

Comprehensive and security Electron template (TypeScript + Vue3 + Vite).
https://electron-vite.org
147 stars 28 forks source link

Suggestion for an electron-vite-boilerplate-lit #5

Closed rudifa closed 2 years ago

rudifa commented 2 years ago

Hello @alex8088

I was looking for help in creating an Electron app managed by Vite and using Lit components, and I found this repo, which uses Vue components.

I cloned your electron-vite-boilerplate and I ran successfully the resulting Vue app (both dev and build:mac).

I congratulate you for the nice clean project, which runs without any problems.

Since I have more experience with Lit than with Vue, React, Svelte, Solid, e.t.c., I tried (and succeeded) to transform your project into my electron-vite-boilerplate-lit, which I just published on github.

I preserved the project code structure, but I replaced the Vite support and components by the similar Lit support and components.

Now, could you please look at my project and comment on it? Then, if you find it interesting and useful, would you consider adding a fork or clone of my project to your repo, for better visibility? You would be welcome to modify and improve it, as you would see fit.

I also looked at you collection of templates in your quick-start...create-electron, and I created a couple of test projects (a vanilla and a vue project). These also ran without any problems.

My alternate or additional suggestion would be to add the lit and lit-ts templates to your collection. I am sure that this would be easy to do for you, as you know your workflow for adding and testing these templates.

Please let me know what you think of my suggestions.

Best regards, @rudifa

alex8088 commented 2 years ago

Hi, @rudifa

Thanks for your interest and suggestions in this project. I reviewed your project and made a PR. Regarding create-electron support for lit and lit-ts templates, maybe it will be implemented in a future version.

If you have any questions, you can submit a new issue at any time.