search

alex9311 / information-retrieval

TU Delft, Masters Software Technology, Information Retrieval, 3rd Quarter 2015
1 stars 2 forks source link

added image uploading implementation #44

Closed alex9311 closed 9 years ago

alex9311 commented 9 years ago

Hey @GizKockesen ,

I got image uploading working, it just needs to be ported into the submit page now. I thought we could first merge my branch into yours, since yours is the submit page branch. Is that OK?

If you look at app/pages/upload_form.php theres a piece of a form that should be ported into the submission page. I'm not sure how we'll give the database the URL yet though.

Do you want to update your submit page to have that snippet for uploading the image?

GizKockesen commented 9 years ago

Great! Yeah I will update the submit page both with your code and the database connection info now :) I just have to copy and paste your code to the form I guess? On 13 Mar 2015 14:23, "Alex Simes" notifications@github.com wrote:

Hey @GizKockesen https://github.com/GizKockesen ,

I got image uploading working, it just needs to be ported into the submit page now. I thought we could first merge my branch into yours, since yours is the submit page branch. Is that OK?

If you look at app/pages/upload_form.php theres a piece of a form that should be ported into the submission page. I'm not sure how we'll give the database the URL yet though.

Do you want to update your submit page to have that snippet for uploading

the image?

You can view, comment on, or merge this pull request online at:

https://github.com/alex9311/TUD-Information-Retrieval-Group-02/pull/44 Commit Summary

  • added image uploading implementation

File Changes

Patch Links:

- https://github.com/alex9311/TUD-Information-Retrieval-Group-02/pull/44.patch

https://github.com/alex9311/TUD-Information-Retrieval-Group-02/pull/44.diff

— Reply to this email directly or view it on GitHub https://github.com/alex9311/TUD-Information-Retrieval-Group-02/pull/44.

alex9311 commented 9 years ago

Yep, copy pasting the form piece sounds good!

And if you go to this pull request in your browser: https://github.com/alex9311/TUD-Information-Retrieval-Group-02/pull/44 you can push the green "Merge pull request" button to bring my branch into yours.