Feedback chart import should import star power and other markings

alex9490 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire

Other

0 stars 0 forks source link

Feedback chart import should import star power and other markings #105

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

I need to get some info on how this information is stored in the .chart file 
so it can be imported.

Original issue reported on code.google.com by xander4j...@yahoo.com on 25 May 2010 at 11:19

GoogleCodeExporter commented 8 years ago

Supposedly, "# = S 2 #" entries in the instrument note sections define star 
power. 
"# = S 0 #" and "# = S 1 #" are reportedly "player sections" for player 1 and 2
respectively, used in "face off" mode:

http://www.dotblip.com/feedback/index.php?page=faq

My chart parser is ignoring these section events, but I can easily parse them 
in. 
Just let me know how you'd like them stored.  I could make a status flag in the
dbNotelist structure (I should probably rename the structure), so that it 
remembers
whether it is within a player 1, player 2 or SP section.

Original comment by raynebc on 25 May 2010 at 11:36

GoogleCodeExporter commented 8 years ago

It would be enough to just have a structure with chartpos and duration of each 
'S' 
event. Then I can traverse the list and add star power sections easily. Player 
sections could be ignored but you might as well store those in case that 
feature gets 
added to EOF.

You could just as easily store them in the note list (since that's the way 
Feedback 
stores them) with some sort of indicator that they are section markers. Either 
way I 
could get them to import with little effort.

Original comment by xander4j...@yahoo.com on 25 May 2010 at 11:53

GoogleCodeExporter commented 8 years ago

Original comment by raynebc on 26 May 2010 at 12:21

Changed state: Started

GoogleCodeExporter commented 8 years ago

r190 updates the chart parsing logic to store section information so EOF can 
use it
to generate Star Power phrases.

Original comment by raynebc on 26 May 2010 at 12:26

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Original comment by xander4j...@yahoo.com on 26 May 2010 at 1:04

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

Original comment by xander4j...@yahoo.com on 26 May 2010 at 1:04

Changed state: Started

GoogleCodeExporter commented 8 years ago

I added the necessary logic to import star power sections. Unfortunately I'm 
not 
getting any dbNotes when traversing the notes linked list. I think they are 
still 
being skipped.

Original comment by xander4j...@yahoo.com on 26 May 2010 at 1:18

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

I meant dbNotes for the player sections. I'm still getting regular notes.

Original comment by xander4j...@yahoo.com on 26 May 2010 at 1:19

GoogleCodeExporter commented 8 years ago

Fixed.  Silly mistake on my part :)

Original comment by raynebc on 26 May 2010 at 1:45

GoogleCodeExporter commented 8 years ago

Original comment by xander4j...@yahoo.com on 26 May 2010 at 3:21

Changed state: Started

GoogleCodeExporter commented 8 years ago

I think all the available information in Feedback charts is now imported. I'm 
marking 
this issue as fixed for now.

Original comment by xander4j...@yahoo.com on 26 May 2010 at 3:28

Changed state: Fixed