alex9490 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Allow cue sounds to be re-assigned #174

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Now that a dialog menu for selecting the vocal percussion cue sound exists, it 
should be relatively simple to expand it to allow other cues to have their 
sound chosen.  I was thinking something like another set of radio buttons 
reflecting the cue being changed:
Metronome, clap, vocal percussion

Those radio buttons would need to trigger the available sound radio buttons to 
be redrawn.  For example, if the "metronome" radio button was selected, the 
currently active metronome cue would have to be selected amongst the other 
radio button group.

This would also be a pretty good way to present the option of additional vocal 
tone sets.  Besides a grand piano tone set, there may be some others that would 
be useful.

To make eof_menu_audio_cues() more efficient, it may be useful to store the 
cues' SAMPLE pointers in an array, so that eof_audio_cues_dialog[X] could refer 
to eof_audio_cues[X].  Then instead of needing a conditional block for each 
sample, a simple for loop can be implemented:

SAMPLE **selected = &(cue being changed);
int *selectednum = &(selected cue's number variable);

for(x=10;x<=29;x++)
{
  if(eof_audio_cues_dialog[x].flags == D_SELECTED)
  {
    *selected = eof_audio_cues[X];
    *selectednum = X;
  }
}

Original issue reported on code.google.com by raynebc on 28 Sep 2010 at 4:41

GoogleCodeExporter commented 8 years ago
This enhancement would also be an ideal time to be able to set the cue for a 
lane to "off" so the user can have cues for only some lanes if desired.

Original comment by raynebc on 18 Jul 2011 at 8:26

GoogleCodeExporter commented 8 years ago
A dialog that lists each lane, a display string for the current cue for each 
and a "Change cue" button for each would be ideal.  The Change cue button could 
launch the cue selection dialog, which would need to have an "off" option 
added.  If this off option is selected for vocal tones or metronome, it should 
just toggle disable that cue instead of changing the cue selection for it.

An option to be able to set different cues for cymbals versus toms will likely 
be requested.

Original comment by raynebc on 18 May 2012 at 6:20

GoogleCodeExporter commented 8 years ago
The drum cues will be tracked in issue 206.

Original comment by raynebc on 18 May 2012 at 6:36