search

alex9849 / advanced-region-market

A Bukkit/Spigot plugin for renting/selling WorldGuard regions
https://www.spigotmc.org/resources/advancedregionmarket.58732/
69 stars 44 forks source link

Prices reset to 0$ after last update #127

Open Bloodlex opened 2 years ago

Bloodlex commented 2 years ago

Hey,

After the last 3.4.2 update, many of my regions changed price to 0$ (mostly polygonal ones if that is important), although they had been created previously with autoprice. And creating sign once again with autoprice still doesn't change it.

For now I rolled back to previous version.

Do you have any idea why it could be so?

Thanks for your help.

Best regards, Bloodlex

alex9849 commented 1 year ago

Not really. Maybe the calculations for volumes break in the newest version. I'll need to check that :)

Bloodlex commented 1 year ago

Not really. Maybe the calculations for volumes break in the newest version. I'll need to check that :)

I'd be grateful if you could, thanks a lot 🙂

TheClowner commented 1 year ago

I'm running into this issue myself now, any poly regions just don't calculate a volume - probably since worldguard's .volume() method for poly regions just returns 0 - https://github.com/EngineHub/WorldGuard/blob/20044a72d3f5bd3d6a6a2f1e00e0b7307789bb48/worldguard-core/src/main/java/com/sk89q/worldguard/protection/regions/ProtectedPolygonalRegion.java#L186

I guess maybe ARM used to calculate the volume itself?

Emix33 commented 1 year ago

This "regression"? seems to have occured in commit 2e9d06ec , Before this commit Arm did indeed workaround the worldguard bug by calculating the volume for polygonal regions itself. I dont know why this was changed, or if it was intentional.

Bloodlex commented 1 year ago

This "regression"? seems to have occured in commit 2e9d06e , Before this commit Arm did indeed workaround the worldguard bug by calculating the volume for polygonal regions itself. I dont know why this was changed, or if it was intentional.

Yes, it worked before.