search

alexZajac / react-native-skeleton-content

A customizable skeleton-like loading placeholder for react native projects using expo.
https://www.npmjs.com/package/react-native-skeleton-content
MIT License
614 stars 134 forks source link

Remove React Native Reanimated 2 as direct dependency #57

Closed emmbyiringiro closed 1 year ago

emmbyiringiro commented 2 years ago

Most time, apps are using React Navigation or another library that uses react-native-reanimated as a dependency. Those libraries define their own Reanimated dependency version which does not match by version defined by react-native-skeleton-content which result in this issue - https://github.com/software-mansion/react-native-reanimated/issues/1781

This should resolve by using yarn resolutions inside Expo Go and in production with expo build:android but fail with new EXPO EAS build.

By remove react-native-reanimated as direct dependency from here, developer will install react-native-reanimated version compatible with EXPO SDK by using expo install react-native-reanimated and all libraries will use that version compatible with EXPO SDK.

sebi75 commented 2 years ago

@alexZajac please take a look at this, it would be really useful. I also can't use it right now because of reanimated version collision

y3n3rrr commented 2 years ago

@alexZajac hey dude, do you consider this fix? otherwise this package will not be useable. crashes app now

alexZajac commented 2 years ago

Can you double-check if PR #75 (now merged and published) fixes this?

alexZajac commented 1 year ago

Closing as no update from requester.

Alecattie commented 1 year ago

Hello, could you please remove it? I am having issues with duplicate dependencies

thongle12 commented 1 year ago

this package can not be used without fixing this issue. crashes app now