alexa-games / skill-flow-builder

Development suite that helps you create narrative-driven Alexa skills, including a GUI editor and CLI

Other

69 stars 19 forks source link

fix: stop the deletion of devDependencies in stageCommand #24

Closed tyliec closed 3 years ago

tyliec commented 3 years ago

fix: stop the deletion of devDependencies in stageCommand

Description

Instead of delete devDependenices manually, we should probably rely on ASK CLI V2 to do npm install --production

Motivation and Context

Remove unneeded lines of code.

Testing

yarn test.

Deployed a story with the line deleted and deployed a story as is. Both produced the same result with the same lambda file size.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[X] I have read the README document
[ ] I have added tests to cover my changes
[X] All new and existing tests passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.