Include S3 domain and default to HTTPS for VoiceOverExtension
Description
Add s3-domain-name to the URL used for the VoiceOverExtension during the SFB CLI import command. Also updated the urlExists command in the VoiceOverExtension to default to port 443 for HTTPS.
Motivation and Context
Customers can override the S3 domain to support multiple regions, so the VoiceOverExtension should support that as well. HTTPS is more secure than HTTP, so it makes sense to default to it in this case as S3 buckets support and prefer HTTPS.
Testing
yarn test - includes integration test for existing URL examples.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Include S3 domain and default to HTTPS for VoiceOverExtension
Description
Add
s3-domain-nameto the URL used for the VoiceOverExtension during the SFB CLI import command. Also updated the urlExists command in the VoiceOverExtension to default to port 443 for HTTPS.Motivation and Context
Customers can override the S3 domain to support multiple regions, so the VoiceOverExtension should support that as well. HTTPS is more secure than HTTP, so it makes sense to default to it in this case as S3 buckets support and prefer HTTPS.
Testing
yarn test- includes integration test for existing URL examples.Types of changes
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.