alexa-games / skill-flow-builder

Development suite that helps you create narrative-driven Alexa skills, including a GUI editor and CLI

Other

69 stars 19 forks source link

fix: Optimized regular expressions within the editor #44

Closed toorooji closed 3 years ago

toorooji commented 3 years ago

Title

Optimized regular expressions within the editor

Description

Some of the regular expressions being used allowed backtracing. This change removes that backtracing by removing unnecessary nested captures.

Motivation and Context

The goal of this change is to prevent backtracing that could cause regular expressions to take longer than necessary.

Testing

Automated tests were successful, verified expected inputs manually and also verified a skill built using SFB.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[X] I have read the README document
[ ] I have added tests to cover my changes
[X] All new and existing tests passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.