alexa-games / skill-flow-builder

Development suite that helps you create narrative-driven Alexa skills, including a GUI editor and CLI

Other

69 stars 17 forks source link

fix: Do not sanitize backslash on Windows #46

Closed anfazio closed 3 years ago

anfazio commented 3 years ago

Title

fix: Do not sanitize backslash on Windows

Description

sanitizeCommandLineParameter no longer removes backslash \ on Windows.

Motivation and Context

On Windows machines, we should not be removing backslash when sanitizing command-line inputs because backslash is a valid path separator on Windows.

Testing

Built on Windows, ran unit tests, simulated skill

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.