alexa-games / skill-flow-builder

Development suite that helps you create narrative-driven Alexa skills, including a GUI editor and CLI

Other

69 stars 19 forks source link

feat: Adding internal features (*then, base model, detailed address, resume_save, fix post() executing twice at >>PAUSE) #49

Closed ngaiaaro closed 3 years ago

ngaiaaro commented 3 years ago

Title

Adding internal features (*then, base model, detailed address, resume_save, fix post() executing twice at >>PAUSE)

Description

Including *then as a valid scene property
Base model support enables cataloging of sample utterances, additional model attributes enables fallbackSensitivity
Adding variationIndex/line to call stack address allows scene to finish executing before >>RETURN, resume_save reloads system_utteranceChoiceMap after resumeStory deletes it
Bug fix for post() executing twice during >>PAUSE

Motivation and Context

One of the Alexa internal teams is migrating to use Skill Flow Builder on Github. In order to do this, these features and fixes need to be included.

Testing

Built these changes into the internal skill, and deployed them. Tested using manual inspection, unit tests, and integration tests.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project
[X] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[X] I have read the README document
[ ] I have added tests to cover my changes
[X] All new and existing tests passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

anfazio commented 3 years ago

Please have your PR target the develop branch before I can approve