alexa-games / skills-gameon-sdk-js

The Skills GameOn SDK (Beta) is a Node.js package that makes creating leaderboards and competitions, powered by Amazon GameOn, easier for Alexa Skill developers.

https://skills-gameon-sdk.github.io

Apache License 2.0

19 stars 11 forks source link

fix: samples does not export refreshPlayerSession function #21

Closed hideokamoto closed 4 years ago

hideokamoto commented 4 years ago

Title

I think the sample project has a issue.

Description

In https://github.com/alexa-games/skills-gameon-sdk-js/blob/master/samples/word-word-lite/src/index.js#L67 the GameOn.refreshPlayerSession is defined in gameOn.js but the function does not exported.

Issue link(s) - Optional

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[ ] I confirm that this pull request can be released under the Apache 2 license

superkew commented 4 years ago

Thanks for the PR!

Could you please update it to merge to develop instead of master.

greghroberts commented 4 years ago

@hideokamoto let us know if you can update this to develop vs master.

hideokamoto commented 4 years ago

Sorry to late. I've change the base branch from master to develop.