Node 7.10.0 and 7.10.1 fail custom binding tests

alexa-js / alexa-app-server

An Alexa app server for alexa-app.

MIT License

401 stars 116 forks source link

Node 7.10.0 and 7.10.1 fail custom binding tests #115

Closed tejashah88 closed 6 years ago

tejashah88 commented 6 years ago

Latest release (v3.0.2) is breaking on half of the node versions, specifically node v7 being the highest priority to fix.

tejashah88 commented 6 years ago

@dblock

dblock commented 6 years ago

Uh oh, that's not good. I'll try to help but not quickly.

tejashah88 commented 6 years ago

I made a PR (#117) to test if the later node versions are having a similar issue, and it seems that only node 7 has this problem.

tejashah88 commented 6 years ago

Some more testing has led me to the following:

The failing parts of the tests are with custom bindings to a specific host and port, specifically with a refused connection error
Node versions 7.10.0 and 7.10.1 are the only versions breaking, as previous ones are working perfectly
I've been unsuccessful with reproducing the same error on my PC, which is running windows 10 with node 7.10.1

Checking the change log from 7.9.0 to 7.10.0 didn't seem to offer any insight, and I'm not sure how I should proceed further, since this is such an isolated issue.

dblock commented 6 years ago

I would rename this issue into describing the problem on node 7 and remove it from the matrix in a PR and merge that.

tejashah88 commented 6 years ago

That works for now. While we're on the subject, what should we do for node verions 1-3 on the matrix, since they are failing due to the use of arrow functions from the test libraries?