refactored app-server internals

alexa-js / alexa-app-server

An Alexa app server for alexa-app.

MIT License

403 stars 116 forks source link

refactored app-server internals #54

Closed mreinstein closed 7 years ago

mreinstein commented 7 years ago

this shouldn't change the public api at all.

fixes #52 & #21, and partially solves #35

I've deployed this to a test amazon skill and verified that at least the hello_world skill works.

this breaks several tests though. unfortunately I don't have time to update the tests and do the administrative work on this right now. sending this PR so others can review, and pick up where I left off.

Besides the tests and administrative duties, this should be good to go.

mreinstein commented 7 years ago

@tejashah88 @rickwargo @dblock @cpup22

mreinstein commented 7 years ago

also important to note: this PR depends on this landing first: https://github.com/alexa-js/alexa-app/pull/144

dblock commented 7 years ago

I merged #144, I'll try to find time for it, including proper CHANGELOG and UPGRADING from https://github.com/alexa-js/alexa-app/pull/144. Anyone please feel free to pick this up and beat me to it.

rickwargo commented 7 years ago

@mreinstein I'll review by tomorrow.

alexa-app-bot commented 7 years ago

	Warnings
:warning:	Did you forget to update CHANGELOG.md?

Generated by :no_entry_sign: dangerJS

coveralls commented 7 years ago

Coverage decreased (-4.1%) to 91.875% when pulling 1f1d3e51762ebea0e117585e056384da48c7665b on mreinstein:master into c92fbc3c6ea6e05503ef686e76c10f5995641541 on alexa-js:master.

cpup22 commented 7 years ago

Patiently waiting for this to get pulled in. I have a skill under awaiting certification that I know is going to fail because of the verification piece is not properly working. Hoping to swap this out on my backend before they get to that test (a.k.a. before I fail certification) so I don't have to wait another week. So... let me know if you all need help testing this. ;)

dblock commented 7 years ago

I have a merged version in https://github.com/alexa-js/alexa-app-server/pull/56, with a bunch of failing tests. If anyone has quick test fixes, add a comment to that - I'll take a look soon.

tejashah88 commented 7 years ago

Closing this PR in favor of #56

dblock commented 7 years ago

This PR breaks the debugger completely. The test failures are legit, see #56 for some of the fixes. I was able to fix template rendering, but not POST of actual intent data.