Closed zqylur closed 7 years ago
The test feels a bit contrived or at least misplaced. First, it lives inside a test suite that is ensuring that invalid apps are loaded, it should be a standalone check all by itself. Second, this is a perfectly valid app, no? Maybe it doesn't belong in invalid_examples
?
Let me take the valid/invalid app back - I see how you wouldn't want the names to be the way they are setup, so I am cool with the app being where it is. Just split the test about the logger warn message from the tests that ensure invalid apps are loaded at all.
Do you prefer the test to have its own file? Or just a new test in the "test-examples-server-app-loading-fail-checks" file?
I don't have a strong preference.
Looks good, merging.
A minor thing, but something that stymied me for a while when I started using the package. The "loaded app at endpoiont" message is inaccurate if the package.json name and the name used in the Alexa app constructor are different. Changed the message to use the app name, which is where the endpoint actually is.
Happy to flip this as well, and change the router to use the package.json name.