Remove router from `app.express()` configuration

[rickwargo]

alexa-app now deprecates simultaneous use of both expressApp and router in app.express() and generates the following warning:

Usage deprecated: Both 'expressApp' and 'router' are specified.
More details on https://github.com/alexa-js/alexa-app/blob/master/UPGRADING.md

Removing router option from config brings the app-server up-to-date with alexa-app.

[dblock]

Build looks broken. Needs an update for the dependency version?

[rickwargo]

Oops. That's what I get for the "simple, quick fix." This depends on the latest, non-released version of alexa-app. What to put for the dependency?

[dblock]

Looks like you released 3.2.0 so we're in business ;)

[rickwargo]

3.2.0 was not released - at least not by me. I've been waiting...

[dblock]

Oh you and @ajcrites both have red icons and I've been staring at a computer for far too long :) https://github.com/alexa-js/alexa-app/issues/189

[rickwargo]

No worries, @dblock. Need to look into this merge more as the tests have different results on my computer.

[rickwargo]

@dblock I finally got the alexa-app version update to get the tests to pass.

[dblock]

Merged. I haven't looked at that failing test that we xit-ed, what's up with it?

[rickwargo]

It fails on older versions of node, but passes on the last two. It's an odd test using an OOB port number to ensure it is caught. Haven't looked at the code, but perhaps we either check bounds on the port number and fail if OOB or remove the test.

[dblock]

Oh yes I remember. I guess we can leave it as is.

[rickwargo]

@dblock can we release a new alexa-app-server? This and alexa-app are out of sync with respect to the alexa-app deprecation and this PR brings it back to lockstep.

[dblock]

Want to help out and make a release? What's your npm e-mail?

[rickwargo]

@dblock sure. you can use npm at e.p.i.c.m.i.n.d.s..c.o.m (removing superfluous periods)

[dblock]

Sorry it wants an npmjs.com user, my bad.

[rickwargo]

You can use rickwargo as the username

[dblock]

@rickwargo Cool. Follow https://github.com/alexa-js/alexa-app-server/blob/master/RELEASING.md to make a release please.

[rickwargo]

@dblock I missed changing the README to reflect "for the stable release" from "the next release". Should I push a new release?

[rickwargo]

@dblock and left an empty (Next) section in the Changelog. Should I make these corrects, update the RELEASING doc, and push to 3.0.2? Also, what about changes to the RELEASING doc for the next release?

[dblock]

No need to push another release for a missed README, it's fine.

Make sure RELEASING is accurate. We don't change version numbers in it, it's just an example.

[rickwargo]

Haven't changed RELEASING (yet) - I could add more in RELEASING to make what I missed more clear. Since the version numbers were appropriate for this new version, I assumed they were in sync.

[dblock]

They get quickly out of sync :)

[dblock]

@rickwargo I see the release on NPM, but no updates on master for the READMEs and what not, forgot to push them?

[rickwargo]

@dblock wanted to get word back on what to do - then had a 3hr meeting that just finished. will do now. I'll leave RELEASING as-is.

[rickwargo]

@dblock I don't appear to have permission to push the changes to README/CHANGELOG/package.json.

[dblock]

You were sent an invite yesterday :)

[dblock]

https://github.com/alexa-js/alexa-app-server/invitations

[rickwargo]

Missed that entirely, @dblock. Thanks. Pushed to repo.