search

alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 213 forks source link

Fix: card tests weren't failing the suite #315

Closed kobim closed 6 years ago

kobim commented 6 years ago

Tests were completing successfully although 1 case were failing because eventually assertions should be returned in the test case:

screen shot 2018-02-19 at 10 49 50

(committing the fix to the test first, to make sure the fix works and tests fail.)

As for the fix itself, the Card object states the type is required, hence my change added it as a required field.

dblock commented 6 years ago

Does this need to be rebased against https://github.com/alexa-js/alexa-app/pull/316?

kobim commented 6 years ago

Synced with master.

dblock commented 6 years ago

Merged, thank you.