search

alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 212 forks source link

Run dtslint only on the latest node version #329

Closed kobim closed 6 years ago

kobim commented 6 years ago

As dtslint is only required for linting the definition files, and its minimum requirements are node>=6.0.0 (as of dtslint@0.2), there's no need to try and install it for older node versions.

(See issues at alexa-js/alexa-app#324 and palantir/tslint#3792)

Other options which were rejected

  1. Rolling dtslint to v0.1.2 where tslint version is 5.0.0 and maximum TypeScript version is 2.3 (instead of next) The npm install phase passes, but we can't run npm run dtslint as it uses arrow functions (which were only introduced at node v4)
dblock commented 6 years ago

👍

dblock commented 6 years ago

Nice work @kobim thanks!