search

alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 213 forks source link

Making coveralls work again #330

Closed kobim closed 6 years ago

kobim commented 6 years ago

This repo's coveralls page didn't update for a long time (since 9/7/17) due to istanbul's version not being compatible with covering spawned processes. (more on that at gotwarlost/istanbul#262). This PR's coveralls: https://coveralls.io/builds/16371809

Istanbul's 1.x.x-alpha versions solved this issue. (Istanbul has made version 2 already, but that's another integration we should plan for later.)

I think this is important as we are about to enter few new features (e.g. #313) and we should make sure the new code is properly tested and doesn't reduce the coverage of the package. (We can also grant repo permission to @coveralls and get reports on each PR.)

dblock commented 6 years ago

Looks great. @kobim feel free to turn it on for PRs.