search

alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 212 forks source link

.reprompt() not concatenating #359

Closed andrewjhunt closed 6 years ago

andrewjhunt commented 6 years ago

Current code: this.response.response.reprompt.outputSpeech.ssml = SSML.fromStr(str, this.response.response.reprompt.outputSpeech.text);

Correction this.response.response.reprompt.outputSpeech.ssml = SSML.fromStr(str, this.response.response.reprompt.outputSpeech.ssml);

Need to reference the .ssml variable (instead of .text)

dblock commented 6 years ago

Please pull request a test + fix.

andrewjhunt commented 6 years ago

See pull request #364 https://github.com/alexa-js/alexa-app/pull/364

andrewjhunt commented 6 years ago

Is it a bug?

The API doc is not specific but it would be helpful if .reprompt() concatenated just like .say(). And the code looks like it is written to concat but just references the wrong var. But, the unit tests might suggest the current behavior is intentional.