search

alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 212 forks source link

Issue #359 .reprompt() not concatenating #364

Closed andrewjhunt closed 6 years ago

andrewjhunt commented 6 years ago

Fixes #359 https://github.com/alexa-js/alexa-app/blob/master/index.js#L51

Example: the following will speak "1 2" as output. response.reprompt("1").reprompt("2")

Existing unit tests are updated and pass.

NOTE: the doc is not explicit on the expected behavior of multiple reprompts for the same response. I expected that multiple reprompt() would also concatenate as say(). The existing unit tests didn't reflect this but it's not clear that was intentional. Plus the code appeared to reference a non-defined variable.

kobim commented 6 years ago

Hi @andrewjhunt, can you please update the CHANGELOG and also add a note about the concatenation of reprompt()? Other than that, it looks good to me.

andrewjhunt commented 6 years ago

added reprompt() multiple use doc to README.md and index.d.ts